Skip to content

Conversation

@lastCoyotes
Copy link
Member

@lastCoyotes lastCoyotes commented Aug 20, 2025

Fixes #7366

What changes did you make?

  • Added "github-handle" variable

Why did you make the changes (we will use this info to test)?

  • To hold the github handle for each member of the leadership team. Eventually it replace the github and picture variables, reducing redundancy in the project file.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b lastCoyotes-add-github-handle-7366 gh-pages
git pull https://github.com/lastCoyotes/website.git add-github-handle-7366

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 20, 2025
@santi-jose santi-jose self-assigned this Aug 20, 2025
@santi-jose
Copy link
Member

Review ETA: 6 PM 8/20/25
Availability: 5-8PM Monday - Friday

@santi-jose santi-jose self-requested a review August 20, 2025 03:12
Copy link
Member

@santi-jose santi-jose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

What you've done well

  1. PR request done with the proper to and from branches
  2. Checked CodeQL Alerts
  3. Properly linked issue to PR
  4. Changes are applicable and clean
  5. Changes don't affect the view in browser

Good work overall! Your changes match what is requested by the issue. I approve this PR!

Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lastCoyotes!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Site appearance is not affected.
  • A note was included that there were no visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made
  • CodeQL was checked

Again, nice work and thanks for taking the time to contribute to the website!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Aug 20, 2025
@LRenDO LRenDO merged commit bbdfbca into hackforla:gh-pages Aug 20, 2025
9 checks passed
@lastCoyotes lastCoyotes deleted the add-github-handle-7366 branch October 4, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Ren Demeis-Ortiz in _projects/website.md

3 participants